Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/rules: Increase array size to remove SEGV #5429

Closed
wants to merge 2 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #5428

This commit changes the size of reporting variables to be dynamic based
on the buffer ids in use instead of a fixed value to address a SEGV when
the fixed value was less than the max buffer/type id in use.

Link to redmine ticket: 3904

Describe changes:

  • Address clang-format issues

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

This commit changes the size of reporting variables to be dynamic based
on the buffer ids in use instead of a fixed value to address a SEGV when
the fixed value was less than the max buffer/type id in use.
@jlucovsky
Copy link
Contributor Author

There's a related copy/paste error on this line
(void)ConfGetBool("detect.profiling.grouping.include-mpm-stats", &add_rules);

@jlucovsky
Copy link
Contributor Author

Continued in #5435

@jlucovsky jlucovsky closed this Sep 23, 2020
@jlucovsky jlucovsky deleted the 3904/2 branch October 5, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant